Skip to content

Fix: Check for meta type even when using a function reference (fixes #83) #84

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Aug 29, 2019
Merged

Fix: Check for meta type even when using a function reference (fixes #83) #84

merged 1 commit into from
Aug 29, 2019

Conversation

MrHen
Copy link
Contributor

@MrHen MrHen commented Jul 28, 2019

Fixes #83.

aladdin-add
aladdin-add approved these changes Jul 29, 2019
View reviewed changes
Copy link
Contributor

@aladdin-add aladdin-add left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@aladdin-add aladdin-add changed the title Check for meta type even when using a function reference Fix: Check for meta type even when using a function reference (fixes #83) Aug 1, 2019
@aladdin-add
Copy link
Contributor

friendly ping @not-an-aardvark

@not-an-aardvark not-an-aardvark merged commit 38ad521 into eslint-community:master Aug 29, 2019
@MrHen MrHen deleted the feature/83-require-meta-type branch August 30, 2019 14:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aladdin-add aladdin-add aladdin-add approved these changes

@not-an-aardvark not-an-aardvark Awaiting requested review from not-an-aardvark

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

require-meta-type does not work if create is not a function
3 participants
@MrHen @aladdin-add @not-an-aardvark