Skip to content

New: meta-property-ordering (fixes #62) #80

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
May 5, 2019
Merged

New: meta-property-ordering (fixes #62) #80

merged 3 commits into from
May 5, 2019

Conversation

golopot
Copy link
Contributor

@golopot golopot commented Apr 12, 2019

fixes #62

@golopot
Copy link
Contributor Author

golopot commented Apr 12, 2019

Needs to decide the default ordering. After running the rule against the eslint code base. I find that the order [type, docs, fixable, schema, messages, deprecated, replacedBy] is the best match.

Currently this implementation does not care about the ordering of unknown meta properties.

Copy link
Contributor

@aladdin-add aladdin-add left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a few minor suggestions, thanks for the contributing!

@aladdin-add aladdin-add self-requested a review April 20, 2019 07:17
Copy link
Contributor

@aladdin-add aladdin-add left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@not-an-aardvark not-an-aardvark merged commit aebf1cf into eslint-community:master May 5, 2019
@not-an-aardvark
Copy link
Contributor

Published in v2.1.0.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

New: meta-property-ordering
3 participants