Skip to content

Fix: require-meta-type crash when has no meta property #73

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Dec 10, 2018

Conversation

aladdin-add
Copy link
Contributor

@aladdin-add aladdin-add commented Dec 10, 2018

soucecode:

module.exports = {
      create(context) {}
}

output:

 AssertionError [ERR_ASSERTION]: Node must be provided when reporting error if location is not provided
      at assertValidNodeInfo (node_modules/eslint/lib/report-translator.js:96:9)
      at node_modules/eslint/lib/report-translator.js:256:9
      at Object.report (node_modules/eslint/lib/linter.js:812:58)
      at Program (lib/rules/require-meta-type.js:58:19)
      at listeners.(anonymous function).forEach.listener (node_modules/eslint/lib/util/safe-emitter.js:47:58)
      at Array.forEach (<anonymous>)
      at Object.emit (node_modules/eslint/lib/util/safe-emitter.js:47:38)
      at NodeEventGenerator.applySelector (node_modules/eslint/lib/util/node-event-generator.js:251:26)
      at NodeEventGenerator.applySelectors (node_modules/eslint/lib/util/node-event-generator.js:280:22)
      at NodeEventGenerator.enterNode (node_modules/eslint/lib/util/node-event-generator.js:294:14)
      at CodePathAnalyzer.enterNode (node_modules/eslint/lib/code-path-analysis/code-path-analyzer.js:608:23)
      at Traverser.enter [as _enter] (node_modules/eslint/lib/linter.js:865:28)
      at Traverser._traverse (node_modules/eslint/lib/util/traverser.js:132:14)
      at Traverser.traverse (node_modules/eslint/lib/util/traverser.js:115:14)
      at runRules (node_modules/eslint/lib/linter.js:862:15)
      at Linter._verifyWithoutProcessors (node_modules/eslint/lib/linter.js:1003:33)
      at preprocess.map.textBlock (node_modules/eslint/lib/linter.js:1046:35)
      at Array.map (<anonymous>)
      at Linter.verify (node_modules/eslint/lib/linter.js:1045:42)
      at runRuleForItem (node_modules/eslint/lib/testers/rule-tester.js:385:34)
      at testValidTemplate (node_modules/eslint/lib/testers/rule-tester.js:415:28)
      at Context.RuleTester.it (node_modules/eslint/lib/testers/rule-tester.js:573:25)

if a rule has no meta property, eslint is reporting: AssertionError [ERR_ASSERTION]: Node must be provided when reporting error if location is not provided
@not-an-aardvark not-an-aardvark merged commit bc9b1a0 into master Dec 10, 2018
@not-an-aardvark not-an-aardvark deleted the fix/require-meta-type branch December 10, 2018 15:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants