Skip to content

New: no-deprecated-context-methods rule (fixes #40) #41

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 10, 2017

Conversation

not-an-aardvark
Copy link
Contributor

No description provided.

Copy link
Contributor

@aladdin-add aladdin-add left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 👍

@not-an-aardvark not-an-aardvark merged commit 8931504 into master Sep 10, 2017
@not-an-aardvark not-an-aardvark deleted the no-deprecated-context-methods branch September 10, 2017 04:48
@aladdin-add
Copy link
Contributor

I think this can be added to reccommended, since we have a peerdependence eslint > 4.1

@not-an-aardvark
Copy link
Contributor Author

I agree. Although now that we've released v1.0.0, we would need to release v2.0.0 to add it to recommended. It would be nice to not have too many breaking changes.

Maybe we should leave it for now, and then plan to add it to recommended next time we do a major release.

@aladdin-add
Copy link
Contributor

agree! and prefer-output-null for the same reason.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants