Update: add autofixing to test-case-property-ordering. (fixes #31)

[aladdin-add]

enable it on eslint codebase: eslint/eslint#9040

my concern is we didn't enable object-curly-newline, this may fixing some code like this:

{ code: "var [ x, y ] = z",
options: ["always"],
parserOptions: { ecmaVersion: 6 } },

looks so, hmm... strange!

[not-an-aardvark]

my concern is we didn't enable object-curly-newline, this may fixing some code like this:

{ code: "var [ x, y ] = z",
options: ["always"],
parserOptions: { ecmaVersion: 6 } },

Hmm, this doesn't seem ideal. Why not keep the old spacing, and just swap the properties around? That way, comments will also be preserved.

[aladdin-add]

ping @not-an-aardvark

[not-an-aardvark]

Instead of having a special case for trailing commas, would it work to just set finalEnd to the trailing comma if it exists?

const finalEnd = sourceCode.getTokenAfter(last);

[not-an-aardvark]

I think these variable names are confusing because propertyStart and propertyEnd describe the boundaries of the whitespace after the property, not the property itself. Maybe whitespaceStart and whitespaceEnd would be better.

[not-an-aardvark]

Would it be possible to use the new feature in ESLint 4.1.0 where you can return an array of autofixes?

That way, this autofix would be very simple, because it wouldn't be necessary to deal with whitespace or trailing commas:

fix(fixer) {
  return orderMsg.map((key, index) => {
    const propertyToInsert = test.properties[keyNames.indexOf(key)];
    return fixer.replaceText(test.properties[index], sourceCode.getText(propertyToInsert));
  });
}

[aladdin-add]

awesome!!!

[not-an-aardvark]

LGTM. Thanks!