build(deps-dev): bump eslint-plugin-unicorn from 40.1.0 to 43.0.2

build/generate-readme-table.js

@@ -1,7 +1,7 @@
 'use strict';
 
-const fs = require('fs');
-const path = require('path');
+const fs = require('node:fs');
+const path = require('node:path');
 const rules = require('..').rules;
 
 const README_LOCATION = path.resolve(__dirname, '..', 'README.md');

lib/index.js

@@ -9,8 +9,8 @@
 // Requirements
 // ------------------------------------------------------------------------------
 
-const fs = require('fs');
-const path = require('path');
+const fs = require('node:fs');
+const path = require('node:path');
 const packageMetadata = require('../package');
 const PLUGIN_NAME = packageMetadata.name.replace(/^eslint-plugin-/, '');
 
@@ -43,7 +43,6 @@ const allRules = Object.fromEntries(
 
 module.exports.rules = allRules;
 
-// eslint-disable-next-line unicorn/prefer-object-from-entries -- this is fine for now
 module.exports.configs = Object.keys(configFilters).reduce(
   (configs, configName) => {
     return Object.assign(configs, {

lib/rules/require-meta-docs-url.js

@@ -8,7 +8,7 @@
 // Requirements
 // -----------------------------------------------------------------------------
 
-const path = require('path');
+const path = require('node:path');
 const util = require('../utils');
 const { getStaticValue } = require('eslint-utils');
 

lib/utils.js

@@ -41,7 +41,6 @@ const INTERESTING_RULE_KEYS = new Set(['create', 'meta']);
  * @returns Object
  */
 function collectInterestingProperties(properties, interestingKeys) {
-  // eslint-disable-next-line unicorn/prefer-object-from-entries -- this is fine for now
   return properties.reduce((parsedProps, prop) => {
     const keyValue = module.exports.getKeyName(prop);
     if (interestingKeys.has(keyValue)) {
@@ -119,136 +118,132 @@ function isTypeScriptRuleHelper(node) {
  * Helper for `getRuleInfo`. Handles ESM and TypeScript rules.
  */
 function getRuleExportsESM(ast, scopeManager) {
-  return (
-    ast.body
-      .filter((statement) =>
-        [
-          'ExportDefaultDeclaration', // export default rule;
-          'TSExportAssignment', // export = rule;
-        ].includes(statement.type)
-      )
-      .map((statement) => statement.declaration || statement.expression)
-      // eslint-disable-next-line unicorn/prefer-object-from-entries -- this is fine for now
-      .reduce((currentExports, node) => {
-        if (node.type === 'ObjectExpression') {
-          // Check `export default { create() {}, meta: {} }`
-          return collectInterestingProperties(
-            node.properties,
-            INTERESTING_RULE_KEYS
-          );
-        } else if (isFunctionRule(node)) {
-          // Check `export default function(context) { return { ... }; }`
-          return { create: node, meta: null, isNewStyle: false };
-        } else if (isTypeScriptRuleHelper(node)) {
-          // Check `export default someTypeScriptHelper({ create() {}, meta: {} });
+  return ast.body
+    .filter((statement) =>
+      [
+        'ExportDefaultDeclaration', // export default rule;
+        'TSExportAssignment', // export = rule;
+      ].includes(statement.type)
+    )
+    .map((statement) => statement.declaration || statement.expression)
+
+    .reduce((currentExports, node) => {
+      if (node.type === 'ObjectExpression') {
+        // Check `export default { create() {}, meta: {} }`
+        return collectInterestingProperties(
+          node.properties,
+          INTERESTING_RULE_KEYS
+        );
+      } else if (isFunctionRule(node)) {
+        // Check `export default function(context) { return { ... }; }`
+        return { create: node, meta: null, isNewStyle: false };
+      } else if (isTypeScriptRuleHelper(node)) {
+        // Check `export default someTypeScriptHelper({ create() {}, meta: {} });
+        return collectInterestingProperties(
+          node.arguments[0].properties,
+          INTERESTING_RULE_KEYS
+        );
+      } else if (node.type === 'Identifier') {
+        // Rule could be stored in a variable before being exported.
+        const possibleRule = findVariableValue(node, scopeManager);
+        if (possibleRule) {
+          if (possibleRule.type === 'ObjectExpression') {
+            // Check `const possibleRule = { ... }; export default possibleRule;
+            return collectInterestingProperties(
+              possibleRule.properties,
+              INTERESTING_RULE_KEYS
+            );
+          } else if (isFunctionRule(possibleRule)) {
+            // Check `const possibleRule = function(context) { return { ... } }; export default possibleRule;`
+            return { create: possibleRule, meta: null, isNewStyle: false };
+          } else if (isTypeScriptRuleHelper(possibleRule)) {
+            // Check `const possibleRule = someTypeScriptHelper({ ... }); export default possibleRule;
+            return collectInterestingProperties(
+              possibleRule.arguments[0].properties,
+              INTERESTING_RULE_KEYS
+            );
+          }
+        }
+      }
+      return currentExports;
+    }, {});
+}
+
+/**
+ * Helper for `getRuleInfo`. Handles CJS rules.
+ */
+function getRuleExportsCJS(ast, scopeManager) {
+  let exportsVarOverridden = false;
+  let exportsIsFunction = false;
+  return ast.body
+    .filter((statement) => statement.type === 'ExpressionStatement')
+    .map((statement) => statement.expression)
+    .filter((expression) => expression.type === 'AssignmentExpression')
+    .filter((expression) => expression.left.type === 'MemberExpression')
+
+    .reduce((currentExports, node) => {
+      if (
+        node.left.object.type === 'Identifier' &&
+        node.left.object.name === 'module' &&
+        node.left.property.type === 'Identifier' &&
+        node.left.property.name === 'exports'
+      ) {
+        exportsVarOverridden = true;
+        if (isFunctionRule(node.right)) {
+          // Check `module.exports = function (context) { return { ... }; }`
+
+          exportsIsFunction = true;
+          return { create: node.right, meta: null, isNewStyle: false };
+        } else if (node.right.type === 'ObjectExpression') {
+          // Check `module.exports = { create: function () {}, meta: {} }`
+
           return collectInterestingProperties(
-            node.arguments[0].properties,
+            node.right.properties,
             INTERESTING_RULE_KEYS
           );
-        } else if (node.type === 'Identifier') {
+        } else if (node.right.type === 'Identifier') {
           // Rule could be stored in a variable before being exported.
-          const possibleRule = findVariableValue(node, scopeManager);
+          const possibleRule = findVariableValue(node.right, scopeManager);
           if (possibleRule) {
             if (possibleRule.type === 'ObjectExpression') {
-              // Check `const possibleRule = { ... }; export default possibleRule;
+              // Check `const possibleRule = { ... }; module.exports = possibleRule;
               return collectInterestingProperties(
                 possibleRule.properties,
                 INTERESTING_RULE_KEYS
               );
             } else if (isFunctionRule(possibleRule)) {
-              // Check `const possibleRule = function(context) { return { ... } }; export default possibleRule;`
+              // Check `const possibleRule = function(context) { return { ... } }; module.exports = possibleRule;`
               return { create: possibleRule, meta: null, isNewStyle: false };
-            } else if (isTypeScriptRuleHelper(possibleRule)) {
-              // Check `const possibleRule = someTypeScriptHelper({ ... }); export default possibleRule;
-              return collectInterestingProperties(
-                possibleRule.arguments[0].properties,
-                INTERESTING_RULE_KEYS
-              );
             }
           }
         }
-        return currentExports;
-      }, {})
-  );
-}
-
-/**
- * Helper for `getRuleInfo`. Handles CJS rules.
- */
-function getRuleExportsCJS(ast, scopeManager) {
-  let exportsVarOverridden = false;
-  let exportsIsFunction = false;
-  return (
-    ast.body
-      .filter((statement) => statement.type === 'ExpressionStatement')
-      .map((statement) => statement.expression)
-      .filter((expression) => expression.type === 'AssignmentExpression')
-      .filter((expression) => expression.left.type === 'MemberExpression')
-      // eslint-disable-next-line unicorn/prefer-object-from-entries -- this is fine for now
-      .reduce((currentExports, node) => {
-        if (
-          node.left.object.type === 'Identifier' &&
-          node.left.object.name === 'module' &&
-          node.left.property.type === 'Identifier' &&
-          node.left.property.name === 'exports'
-        ) {
-          exportsVarOverridden = true;
-          if (isFunctionRule(node.right)) {
-            // Check `module.exports = function (context) { return { ... }; }`
-
-            exportsIsFunction = true;
-            return { create: node.right, meta: null, isNewStyle: false };
-          } else if (node.right.type === 'ObjectExpression') {
-            // Check `module.exports = { create: function () {}, meta: {} }`
+        return {};
+      } else if (
+        !exportsIsFunction &&
+        node.left.object.type === 'MemberExpression' &&
+        node.left.object.object.type === 'Identifier' &&
+        node.left.object.object.name === 'module' &&
+        node.left.object.property.type === 'Identifier' &&
+        node.left.object.property.name === 'exports' &&
+        node.left.property.type === 'Identifier' &&
+        INTERESTING_RULE_KEYS.has(node.left.property.name)
+      ) {
+        // Check `module.exports.create = () => {}`
+
+        currentExports[node.left.property.name] = node.right;
+      } else if (
+        !exportsVarOverridden &&
+        node.left.object.type === 'Identifier' &&
+        node.left.object.name === 'exports' &&
+        node.left.property.type === 'Identifier' &&
+        INTERESTING_RULE_KEYS.has(node.left.property.name)
+      ) {
+        // Check `exports.create = () => {}`
 
-            return collectInterestingProperties(
-              node.right.properties,
-              INTERESTING_RULE_KEYS
-            );
-          } else if (node.right.type === 'Identifier') {
-            // Rule could be stored in a variable before being exported.
-            const possibleRule = findVariableValue(node.right, scopeManager);
-            if (possibleRule) {
-              if (possibleRule.type === 'ObjectExpression') {
-                // Check `const possibleRule = { ... }; module.exports = possibleRule;
-                return collectInterestingProperties(
-                  possibleRule.properties,
-                  INTERESTING_RULE_KEYS
-                );
-              } else if (isFunctionRule(possibleRule)) {
-                // Check `const possibleRule = function(context) { return { ... } }; module.exports = possibleRule;`
-                return { create: possibleRule, meta: null, isNewStyle: false };
-              }
-            }
-          }
-          return {};
-        } else if (
-          !exportsIsFunction &&
-          node.left.object.type === 'MemberExpression' &&
-          node.left.object.object.type === 'Identifier' &&
-          node.left.object.object.name === 'module' &&
-          node.left.object.property.type === 'Identifier' &&
-          node.left.object.property.name === 'exports' &&
-          node.left.property.type === 'Identifier' &&
-          INTERESTING_RULE_KEYS.has(node.left.property.name)
-        ) {
-          // Check `module.exports.create = () => {}`
-
-          currentExports[node.left.property.name] = node.right;
-        } else if (
-          !exportsVarOverridden &&
-          node.left.object.type === 'Identifier' &&
-          node.left.object.name === 'exports' &&
-          node.left.property.type === 'Identifier' &&
-          INTERESTING_RULE_KEYS.has(node.left.property.name)
-        ) {
-          // Check `exports.create = () => {}`
-
-          currentExports[node.left.property.name] = node.right;
-        }
-        return currentExports;
-      }, {})
-  );
+        currentExports[node.left.property.name] = node.right;
+      }
+      return currentExports;
+    }, {});
 }
 
 /**
@@ -600,7 +595,6 @@ module.exports = {
 
     if (reportArgs.length === 1) {
       if (reportArgs[0].type === 'ObjectExpression') {
-        // eslint-disable-next-line unicorn/prefer-object-from-entries -- this is fine for now
         return reportArgs[0].properties.reduce((reportInfo, property) => {
           const propName = module.exports.getKeyName(property);
 

package.json

@@ -59,7 +59,7 @@
     "eslint-plugin-markdown": "^3.0.0",
     "eslint-plugin-node": "^11.1.0",
     "eslint-plugin-prettier": "^4.2.1",
-    "eslint-plugin-unicorn": "^40.1.0",
+    "eslint-plugin-unicorn": "^43.0.2",
     "eslint-scope": "^7.1.1",
     "espree": "^9.4.0",
     "husky": "^8.0.1",

tests/build/generate-readme-table.js

@@ -1,7 +1,7 @@
 'use strict';
 
-const fs = require('fs');
-const path = require('path');
+const fs = require('node:fs');
+const path = require('node:path');
 const assert = require('chai').assert;
 
 describe('table in README.md', () => {

tests/lib/rule-setup.js

@@ -1,7 +1,7 @@
 'use strict';
 
-const { readdirSync, readFileSync } = require('fs');
-const path = require('path');
+const { readdirSync, readFileSync } = require('node:fs');
+const path = require('node:path');
 const assert = require('chai').assert;
 const plugin = require('../..');
 

tests/lib/utils.js

@@ -1,6 +1,6 @@
 'use strict';
 
-const { inspect } = require('util');
+const { inspect } = require('node:util');
 const lodash = require('lodash');
 const espree = require('espree');
 const eslintScope = require('eslint-scope');