Skip to content

Breaking: add some rules to recommended config #25

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jul 23, 2017
Merged

Breaking: add some rules to recommended config #25

merged 2 commits into from
Jul 23, 2017

Conversation

aladdin-add
Copy link
Contributor

@aladdin-add aladdin-add commented Jul 22, 2017 •
edited
Loading

added these rules:

  • no-identical-tests
  • prefer-output-null
  • fixer-return

these are not added:

  • consistent-output
  • prefer-placeholders
  • report-message-format

@not-an-aardvark
Copy link
Contributor

I'm not sure about prefer-output-null because some users might have to support an old version of ESLint where output: null doesn't work. I like the other suggestions though.

Also, I think these should be Breaking: rather than Update:.

@aladdin-add aladdin-add changed the title Recommended changes. [Breaking] Recommended changes. Jul 22, 2017
@not-an-aardvark not-an-aardvark changed the title [Breaking] Recommended changes. Breaking: add some rules to recommended config Jul 23, 2017
@aladdin-add aladdin-add merged commit 8ac484c into eslint-community:master Jul 23, 2017
@aladdin-add aladdin-add deleted the recommended branch July 23, 2017 13:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@not-an-aardvark not-an-aardvark not-an-aardvark approved these changes

Assignees
No one assigned
Labels
accepted
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@aladdin-add @not-an-aardvark