Skip to content

chore: use conventional commits #221

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 7 commits into from
Oct 19, 2021
Merged

Conversation

aladdin-add
Copy link
Contributor

@aladdin-add aladdin-add commented Oct 18, 2021

  • chore: auto-changelog => conventional-changelog (fixes release improvement #220)
  • docs: add conventional commits badge
  • chore: add commitlint & husky

the result would look like(the versions were only for testing, and not published):
image

@aladdin-add aladdin-add force-pushed the chore/conventional-commits branch from b36df1a to d76f265 Compare October 18, 2021 10:00
@aladdin-add aladdin-add marked this pull request as draft October 18, 2021 10:13
@aladdin-add aladdin-add force-pushed the chore/conventional-commits branch from 300f20a to 0c51a4e Compare October 18, 2021 10:17
Copy link
Member

@bmish bmish left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This works for me.

I personally use release-it-lerna-changelog myself which is based off github PR tags (example changelog) but I like conventional commits too.

@aladdin-add aladdin-add force-pushed the chore/conventional-commits branch from 0c51a4e to 5864f59 Compare October 19, 2021 02:21
@aladdin-add aladdin-add marked this pull request as ready for review October 19, 2021 02:25
@aladdin-add aladdin-add merged commit 5ba20da into master Oct 19, 2021
@aladdin-add aladdin-add deleted the chore/conventional-commits branch October 19, 2021 02:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

release improvement
2 participants