New: Add catchNoFixerButFixableProperty option (default false) to catch non-fixable rules that enable the fixable property in require-meta-fixable rule
#165
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bmish
force-pushed
the
require-meta-fixable-not-fixable-with-property
branch
3 times, most recently
from
9475e3b to
c325f3f
Compare
…atch non-fixable rules that enable the fixable property in `require-meta-fixable` rule
bmish
force-pushed
the
require-meta-fixable-not-fixable-with-property
branch
from
c325f3f to
817fd7a
Compare
bmish
changed the title
fixable property in require-meta-fixable rulecatchNoFixerButFixableProperty option (default false) to catch non-fixable rules that enable the fixable property in require-meta-fixable rule
aladdin-add
reviewed
Jul 26, 2021
| `, | ||
| options: [{ catchNoFixerButFixableProperty: true }], | ||
| errors: [{ messageId: 'noFixerButFixableValue', type: 'Literal' }], | ||
| }, |
There was a problem hiding this comment.
can you add some tests that sometimes do not have a fixer - it seems a quite common case?
e.g.
// valid
module.exports = {
meta: { fixable: "whitespace" },
create(context) {
foo
? context.report({ node, message, fix })
: context.report({ node, message });
},
};
// invalid
module.exports = {
meta: { fixable: null },
create(context) {
foo
? context.report({ node, message, fix })
: context.report({ node, message });
},
};
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added behind an option due to risk of false positives.
Open to better names for the option.