Fix: Improve detection of static url strings in require-meta-docs-url rule
#162
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bmish
force-pushed
the
require-meta-docs-url-static-fix
branch
from
aad2c10 to
f07ba05
Compare
…url` rule * Add static value detection for `url` variables * Ignore when we can't statically determine the value of a given `url` * Improve reporting location and tests for this * Use `messageId` * Add tests
bmish
force-pushed
the
require-meta-docs-url-static-fix
branch
from
f07ba05 to
0e2b725
Compare
|
Thanks for reviewing the PRs @aladdin-add! I have another one to open after this one. |
aladdin-add
reviewed
Jul 11, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
urlvariablesurl, so people can use their owngetUrl()function if they wantmessageId