Fix: Fix false positives/negatives in require-meta-fixable rule
#158
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bmish
force-pushed
the
require-meta-fixable-fixes
branch
from
51a460d to
c700f40
Compare
False positives fixed: * When `meta.fixable` uses a variable False negatives fixed: * When there's a fixer but `meta.fixable` = null * When there's a fixer but `meta.fixable` = undefined Also improves reporting location.
bmish
force-pushed
the
require-meta-fixable-fixes
branch
from
c700f40 to
0bfea94
Compare
aladdin-add
reviewed
Jul 11, 2021
| }); | ||
| } }; | ||
| ``` | ||
|
|
There was a problem hiding this comment.
why removing the example? it seems a good example to have.
There was a problem hiding this comment.
This example shows the rule without any meta object. I would consider this to be a rare edge case, and I would argue that including too many unimportant edge cases can distract from the primary examples and make the documentation too long and difficult to understand. The key point we're trying to get across is that "fixable being missing" is in invalid case, and that's already covered by the test case above this one.
If you still prefer, I can add it back, but just wanted to make my case against it.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
False positives fixed:
meta.fixableuses a variableFalse negatives fixed:
meta.fixable= nullmeta.fixable= undefinedAlso improves reporting location.
I'll be opening a few more PRs after this to make similar fixes to other rules.