Fix: Fix false negatives and reporting location in require-meta-type rule
#155
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
bmish
commented
Jul 6, 2021
•
bmish
commented
- Fixes false negatives
- Improves the reporting location
bmish
commented
Jul 6, 2021
| create(context) {} | ||
| }; | ||
| `, | ||
| errors: [{ messageId: 'unexpected', type: 'Identifier' }], |
There was a problem hiding this comment.
This test case was valid before (false negative).
bmish
commented
Jul 6, 2021
| create(context) {} | ||
| }; | ||
| `, | ||
| errors: [{ messageId: 'unexpected', type: 'Identifier' }], |
There was a problem hiding this comment.
This test case was valid before (false negative).
bmish
force-pushed
the
require-meta-type-fixes
branch
from
91b39c7 to
e55981d
Compare
bmish
changed the title
require-meta-type rulerequire-meta-type rule
|
@aladdin-add thanks! Several other rules have the same problems so I'll be submitting more PRs in the next few days. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.