Skip to content

Add node_modules to .eslintignore #149

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from

Conversation

bmish
Copy link
Member

@bmish bmish commented Jun 26, 2021

I saw something in this folder getting linted locally.

@aladdin-add
Copy link
Contributor

I don't think it's needed, as eslint ignores node_modules/ by default.

In addition to any patterns in the .eslintignore file, ESLint always follows a couple of implicit ignore rules even if the --no-ignore flag is passed. The implicit rules are as follows:

  • node_modules/ is ignored.
  • dot-files (except for .eslintrc.*), as well as dot-folders and their contents, are ignored.

https://eslint.org/docs/user-guide/configuring/ignoring-code#the-eslintignore-file

@bmish
Copy link
Member Author

bmish commented Jul 2, 2021

@aladdin-add that's what I thought. I figured out the actual issue though and opened up a replacement fix: #154

@bmish bmish closed this Jul 2, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants