Skip to content

Update fixer-return rule to handle arrow function expressions #144

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 24, 2021

Conversation

bmish
Copy link
Member

@bmish bmish commented Jun 23, 2021

Also improves test coverage including updating the tests to ensure each violation is reported at the correct location (since the location differs depending on the function type).

The lack of coverage for arrow functions was a bug / omission in the rule.

@aladdin-add aladdin-add self-requested a review June 24, 2021 00:19
Copy link
Contributor

@aladdin-add aladdin-add left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@aladdin-add aladdin-add merged commit 6762a3f into eslint-community:master Jun 24, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants