Flag a violation when rule options are used but an empty schema is specified in require-meta-schema rule
#138
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bmish
force-pushed
the
require-meta-schema-detect-usage
branch
2 times, most recently
from
a2fc7fe to
d01141d
Compare
bmish
changed the title
require-meta-schema rulerequire-meta-schema rule
…is present in `require-meta-schema` rule This new check is similar to how: * `require-meta-fixable` checks that `fixable: true` is specified when an autofixer is found * `require-meta-has-suggestions` checks that `hasSuggestions: true` is specified when suggestions are provided Note: this is *not* a breaking change, since ESLint itself already prevents rules from using options when an empty rule schema is specified, so it's not possible that this new violation could be flagged on existing rules.
bmish
force-pushed
the
require-meta-schema-detect-usage
branch
from
d01141d to
ba05f82
Compare
|
yes! per eslint's versioning policy(https://github.com/eslint/eslint#semantic-versioning-policy), it can be released in a minor. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Flags a violation if an empty schema is specified but rule options are used.
This new check is similar to how:
require-meta-fixablechecks thatfixable: trueis specified when an autofixer is foundrequire-meta-has-suggestionschecks thathasSuggestions: trueis specified when suggestions are providedNote: this is not a breaking change, since ESLint itself already prevents rules from using options when an empty rule schema is specified, so it's not possible that this new violation could be flagged on existing rules.