Add eslint-plugin-unicorn #133
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aladdin-add
reviewed
Jun 17, 2021
| @@ -57,7 +57,7 @@ module.exports = { | |||
| ) { | |||
| const message = reportInfo.message.value || messageStaticValue.value; | |||
| // https://github.com/eslint/eslint/blob/2874d75ed8decf363006db25aac2d5f8991bd969/lib/linter.js#L986 | |||
| const PLACEHOLDER_MATCHER = /\{\{\s*([^{}]+?)\s*\}\}/g; | |||
| const PLACEHOLDER_MATCHER = /{{\s*([^{}]+?)\s*}}/g; | |||
There was a problem hiding this comment.
a false negative of the rule no-useless-escape?
There was a problem hiding this comment.
Looks like it, unicorn/better-regex applies a few more plugins to cleanup the regexp.
There was a problem hiding this comment.
can you file the issue in eslint repo, to make sure we don't lost track of it? thanks!
bmish
force-pushed
the
eslint-plugin-unicorn
branch
2 times, most recently
from
54071e2 to
d0c06c9
Compare
bmish
force-pushed
the
eslint-plugin-unicorn
branch
from
d0c06c9 to
5fbb15b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
All sorts of cool rules for enforcing/converting to better, modern JavaScript code.
Most of this was autofixed. I disabled a few noisy/undesirable rules.
https://github.com/sindresorhus/eslint-plugin-unicorn