add --fix to no-identical-tests. #13
Conversation
aladdin-add
changed the title
|
Thanks for working on these issues! Sorry about the delay, I'm planning to review your PRs in the next day or two.
I think that's fine and we don't have to worry about it here -- if the |
| { code: 'foo', errors: ['bar'] }, | ||
| ] | ||
| }); | ||
| `, |
There was a problem hiding this comment.
Can you add a test where there is no trailing comma?
valid: [
{ code: 'foo' }
]
lib/rules/no-identical-tests.js
Outdated
| const end = sourceCode.getTokenAfter(test); | ||
| return fixer.replaceTextRange( | ||
| // should remove test's trailing comma | ||
| [start.range[1], end.range[end.value === ',' ? 1 : 0]] |
There was a problem hiding this comment.
I think this will handle whitespace differently depending on whether there is a comma. If there is no comma, then all the whitespace up to the next test will be removed. If there is a comma, the whitespace up to the next test will be preserved.
Maybe it would be better to be consistent about handling whitespace.
|
ping @not-an-aardvark |
lib/rules/no-identical-tests.js
Outdated
| fix (fixer) { | ||
| const start = sourceCode.getTokenBefore(test); | ||
| const end = sourceCode.getTokenAfter(test); | ||
| return fixer.replaceTextRange( |
There was a problem hiding this comment.
Nitpick: This can be fixer.removeRange instead of fixer.replaceTextRange.
Actually, maybe that would be a good rule to add to this plugin. 😄
this is WIP, as the trailing commas have not been handled.it simply remove the identical tests, so may cause incorrect indent. any suggestions? @not-an-aardvark