Fix: Rule can't find reference of create function
#107
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fisker
changed the title
fisker
changed the title
create function
|
@aladdin-add No CI running? |
fisker
commented
Apr 9, 2021
| `, { ecmaVersion: 6 }); | ||
| const expected = { | ||
| create: { type: 'Identifier' }, | ||
| meta: { type: 'Identifier' }, |
There was a problem hiding this comment.
This should still break rules like this, It should return the reference. But I'm not going to work on it in this PR.
|
ci was not working somehow ╮(￣▽￣)╭, we are considering switching to gh actions. refs #104 |
not-an-aardvark
approved these changes
Apr 15, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Turns out if
createis a reference, the global scope don't have the reference not only innodejsScope, also broken ifsourceTypeis set to'module'.To find the correct reference, I'm searching all
childScopes, I hope it's fine to do this.Fixes #106