Add rule prefer-object-rule
#101
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aladdin-add
approved these changes
Jun 21, 2020
bmish
requested changes
Jun 21, 2020
| create(context) { | ||
| return { Program() { context.report() } }; | ||
| }, | ||
| }; |
There was a problem hiding this comment.
This looks like a duplicate example of the above.
|
|
||
| module.exports = (context) => { | ||
| return { Program() { context.report() } }; | ||
| }; |
There was a problem hiding this comment.
I personally wouldn't bother showing multiple ways of defining the same function or object. A single function (incorrect) example and a single object (correct) example get the idea across. But up to you.
| return { Program() { context.report() } }; | ||
| }, | ||
| }; | ||
| ``` |
There was a problem hiding this comment.
This rule doc could have a ## References section which links to this doc:
bmish
approved these changes
Jun 21, 2020
not-an-aardvark
approved these changes
Jun 23, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds a simple rule to help enforce that a rule uses object style rule definitions instead of function style.
I wanted this to help me migrate a legacy codebase of ~300 rules.
This rule pairs well and help with the
require-meta-*rules as it allows their fixers to work.Currently those rules will report an error, but not fix function style rules.