Fix a file coping to itself #3344
Conversation
lexmag
force-pushed
the
self-cp-fix
branch
3 times, most recently
from
adee492 to
b606e48
Compare
|
@josevalim this is ready for review. |
| @@ -461,7 +461,7 @@ defmodule File do | |||
| error will be returned. | |||
| """ | |||
| @spec cp(Path.t, Path.t, (Path.t, Path.t -> boolean)) :: :ok | {:error, posix} | |||
| def cp(source, destination, callback \\ fn(_, _) -> true end) do | |||
| def cp(source, destination, callback \\ &path_differs?/2) do | |||
There was a problem hiding this comment.
This means if the user is passing a custom function, they will need to add this logic himself. I don't think this is behaviour we want, right? We don't want to ever copy, we don't want to even invoke the callback. No?
There was a problem hiding this comment.
It feels that path_differs?/2 check out of callback makes this function more rigid.
My thoughts are to let user decide how to handle existence of the destination file even if it's the source itself. I think we could have a public alternative to path_differs?/2. However, it's hard to say what the best for a user before we see it in use. 
There was a problem hiding this comment.
There was a problem hiding this comment.
path_differs?/2 is moved out of callback.
|
❤️ 💚 💙 💛 💜 |
Closes #3155.
Cancels #3156.