File.LinkError - fix confusing wording #14441
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
josevalim
reviewed
Apr 16, 2025
demerphq
force-pushed
the
yves/make_file_link_error_text_less_confusing
branch
from
6e7cdbb to
f115784
Compare
The api for creating links is ln(existing, new) but the old error text said "from existing to new", where I believe it should say "from new to existing". Likely this error came from the example using "source.txt" and "target.txt" and it being natural to say "to target", so this patch also changes the example to use "existing.txt" and "link.txt" as the file names so it reads more naturally.
demerphq
force-pushed
the
yves/make_file_link_error_text_less_confusing
branch
from
f115784 to
eac3b53
Compare
|
💚 💙 💜 💛 ❤️ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The api for links is ln(existing, new) but the old text said "from existing to new", where it should have said "to existing from new".
This fixes the text to make it more clear. Likely this error came from the example using "source.txt" and "target.txt" and it being natural to say "to target".
This changes the example to use "existing.txt" and "link.txt" so it is more obvious what is going on.