Implement optimization of tuple unions #14228
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sabiwara
requested review from
gldubc and
josevalim
and removed request for
gldubc
|
Sorry seems to be a bootstrapping issue, moving this back to draft 😅 |
|
@sabiwara use the |
|
Oh got it. I saw that |
|
It is all a matter of time until some code paths get executed during inference which runs during compilation. We can start by replacing the Map module though, Enum will likely be fine. |
|
dfbf5e5 seemed enough to fix the issue for now, but happy to send a follow-up PR to replace |
|
Wow, there's no equivalent of |
josevalim
approved these changes
Jan 26, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Same idea as #14215 for tuples.