-
Notifications
You must be signed in to change notification settings - Fork 3.4k
support Duration
in Date.range/3
#14172
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes from 1 commit
563fd96
c0b0dd4
c480baf
a31cead
99c0fab
8e0c543
ab237e9
228f1df
104d7b9
c9279d1
66de751
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -84,6 +84,11 @@ defmodule Date do | |
iex> Date.range(~D[1999-01-01], ~D[2000-01-01]) | ||
Date.range(~D[1999-01-01], ~D[2000-01-01]) | ||
|
||
Alternatively, a range may be built from a first `Date` and a `Duration`: | ||
|
||
iex> Date.range(~D[1999-01-01], Duration.new!(year: 1)) | ||
Date.range(~D[1999-01-01], ~D[2000-01-01]) | ||
|
||
A range of dates implements the `Enumerable` protocol, which means | ||
functions in the `Enum` module can be used to work with | ||
ranges: | ||
|
@@ -100,7 +105,7 @@ defmodule Date do | |
|
||
""" | ||
@doc since: "1.5.0" | ||
@spec range(Calendar.date(), Calendar.date()) :: Date.Range.t() | ||
@spec range(Calendar.date(), Calendar.date() | Duration.t()) :: Date.Range.t() | ||
def range(%{calendar: calendar} = first, %{calendar: calendar} = last) do | ||
{first_days, _} = to_iso_days(first) | ||
{last_days, _} = to_iso_days(last) | ||
|
@@ -119,6 +124,11 @@ defmodule Date do | |
range(first, first_days, last, last_days, calendar, step) | ||
end | ||
|
||
def range(%{calendar: calendar} = first, %Duration{} = duration) do | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. shall we allow the keyword list version as well? :) There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. i found that |
||
last = shift(first, duration) | ||
range(first, last) | ||
end | ||
|
||
def range(%{calendar: _, year: _, month: _, day: _}, %{calendar: _, year: _, month: _, day: _}) do | ||
raise ArgumentError, "both dates must have matching calendars" | ||
end | ||
|
@@ -140,7 +150,7 @@ defmodule Date do | |
|
||
""" | ||
@doc since: "1.12.0" | ||
@spec range(Calendar.date(), Calendar.date(), step :: pos_integer | neg_integer) :: | ||
@spec range(Calendar.date(), Calendar.date() | Duration.t(), step :: pos_integer | neg_integer) :: | ||
Date.Range.t() | ||
def range(%{calendar: calendar} = first, %{calendar: calendar} = last, step) | ||
when is_integer(step) and step != 0 do | ||
|
@@ -149,6 +159,11 @@ defmodule Date do | |
range(first, first_days, last, last_days, calendar, step) | ||
end | ||
|
||
def range(%{calendar: calendar} = first, %Duration{} = duration, step) do | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. We should probably guard this too to check that step is a non-zero integer and update the ArgumentError clause & message? |
||
last = shift(first, duration) | ||
range(first, last, step) | ||
end | ||
|
||
def range( | ||
%{calendar: _, year: _, month: _, day: _} = first, | ||
%{calendar: _, year: _, month: _, day: _} = last, | ||
|
Uh oh!
There was an error while loading. Please reload this page.