Do not use protocols during consolidation to avoid races #13856
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
josevalim
commented
Sep 24, 2024
whatyouhide
reviewed
Sep 24, 2024
| @@ -498,7 +498,7 @@ defmodule Protocol do | |||
|
|
|||
| defp extract_matching_by_attribute(paths, prefix, callback) do | |||
| for path <- paths, | |||
| path = to_charlist(path), | |||
| path = if(is_list(path), do: path, else: String.to_charlist(path)), | |||
There was a problem hiding this comment.
My 2c: a comment here would be worth it, because by reading this I’m afraid the first thought would be "oh with to_charlist/1 this could be simpler 😄
whatyouhide
approved these changes
Sep 24, 2024
josevalim
commented
Sep 24, 2024
|
💚 💙 💜 💛 ❤️ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.