Add a rule of thumb to the guide. #13813
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
A rule of thumb when to prefer using `and`, `or` and `not` over `&&`, `||` and `!`
RudolfMan
commented
Sep 6, 2024
Comment on lines
+172
to
+173
| As a rule of thumb, use `and`, `or` and `not` when you are expecting booleans. If any of the arguments are non-boolean, use `&&`, `||` and `!`. | ||
|
|
There was a problem hiding this comment.
I just copied this from the previous source https://github.com/elixir-lang/elixir-lang.github.com/blob/37063abef750a4263d48ea4022634b804dea32ff/getting-started/basic-operators.markdown?plain=1#L74
|
💚 💙 💜 💛 ❤️ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This rule of thumb used to be in the getting started page, but it got dropped when moved to hexdocs, I'm not sure if it was intentional.
It was helpful to point new devs to the suggestion when onboarding to elixir.