Fix relative path resolution in "mix release" for symlinked scripts #13796
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
josevalim
reviewed
Aug 27, 2024
josevalim
reviewed
Aug 27, 2024
josevalim
reviewed
Aug 27, 2024
|
I'm investigating the Windows failing tests |
|
Symlinks are actually tricky on Windows. Maybe you can try using hard link ( |
|
💚 💙 💜 💛 ❤️ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR addresses an issue (#13672) with path resolution in
mix releasewhen scripts are executed via relative symlinks.The original script did not correctly resolve paths, leading to errors when the release script was invoked through a symlink that pointed to a relative path.
The fix ensures that SELF is always resolved to an absolute path, regardless of how the script is invoked.
This update improves the reliability of release scripts in environments where symlinks are used. Additionally, tests have been added to verify that both absolute and relative symlinks work correctly with the updated path resolution logic.