Add map delete, put, fetch type operations #13795
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
josevalim
reviewed
Sep 16, 2024
| end | ||
| end | ||
|
|
||
| def map_update_static_value(descr, key, type) do |
There was a problem hiding this comment.
Suggested change
| def map_update_static_value(descr, key, type) do | |
| defp map_update_static_value(descr, key, type) do |
josevalim
reviewed
Sep 16, 2024
| end | ||
| end | ||
|
|
||
| def map_put_static_value(descr, key, type) do |
There was a problem hiding this comment.
Suggested change
| def map_put_static_value(descr, key, type) do | |
| defp map_put_static_value(descr, key, type) do |
josevalim
reviewed
Sep 16, 2024
| end | ||
|
|
||
| # Directly inserts a key of a given type into every positive and negative map | ||
| def map_put_static(descr, key, type) do |
There was a problem hiding this comment.
Suggested change
| def map_put_static(descr, key, type) do | |
| defp map_put_static(descr, key, type) do |
josevalim
reviewed
Sep 16, 2024
| case :maps.take(:dynamic, descr) do | ||
| :error -> | ||
| cond do | ||
| subtype?(descr, open_map([{key, term()}])) -> map_put_static(descr, key, type) |
There was a problem hiding this comment.
Is there a more efficient way of checking this? Perhaps we could use map_fetch? Perhaps we could simplify this function with map_fetch?
|
💚 💙 💜 💛 ❤️ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add map_delete, map_fetch, map_put operations for map types
Rework function map_split_on_key into two direct functions map_get and map_delete
Add an optimization for map_difference.
If we are doing the difference of an open map with a single key, we can directly compute the difference of that key in both maps to simplify the result.
Also, added the possibility for map keys to be
not_set()since it is used inmap_delete.