Skip to content

Ensure :native is a valid parameter type #13781

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 17, 2024

Conversation

scohen
Copy link
Contributor

@scohen scohen commented Aug 16, 2024

Several of the functions in System that deal with time had a typespec that only allowed the time_unit type even though they accepted the :native time unit. This confuses dialyzer if :native is passed to these functions

Several of the functions in System that deal with time had a typespec
that only allowed the time_unit type even though they accepted the
:native time unit. This confuses dialyzer if :native is passed to
these functions
Copy link
Contributor

@sabiwara sabiwara left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @scohen 💜

@sabiwara sabiwara merged commit b8cec30 into elixir-lang:main Aug 17, 2024
9 checks passed
sabiwara pushed a commit that referenced this pull request Aug 17, 2024
Several of the functions in System that deal with time had a typespec
that only allowed the time_unit type even though they accepted the
:native time unit. This confuses dialyzer if :native is passed to
these functions
@sabiwara
Copy link
Contributor

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants