fix example comment in Enum.slide/3 #13779
Conversation
| @@ -2706,11 +2706,11 @@ defmodule Enum do | |||
| iex> Enum.slide([:a, :b, :c, :d, :e, :f, :g], 5, 1) | |||
| [:a, :f, :b, :c, :d, :e, :g] | |||
|
|
|||
| # Slide a range of elements backward | |||
There was a problem hiding this comment.
Both interpretations can be right, but semantically, it is forward, because we are bringing the elements from 3..5 to position 1 (and as a result, the ones from 1..2 are brought forward, but the ones we specify go back).
There was a problem hiding this comment.
the ones we specify go back
Could you expand on that a little? Which elements are "the ones we specify" and what do you mean by "go back"?
I'd interpret the elements we specify as the 3..5 slice, i.e. elements [:d, :e, :f]. Originally, these elements are in positions 3-5, but after the slide/3 call, they are in positions 1-3. As these elements have moved towards the head of the list, wouldn't this be "going forward"?
There was a problem hiding this comment.
Oh, I see where the confusion is coming from, it is about what is forward, the head or the tail? What if instead of forwards and backwards and we say "towards the head" and "towards the tail"?
There was a problem hiding this comment.
That was indeed the source of my confusion: "forward" being "in the reading direction" vs "toward the list head". I've reworded the change to remove ambiguity. Thanks for clarifying your meaning!
"forward" could mean - towards the head of the list - farther in the reading direction (i.e., farther to the right) By referring instead to the list's head/tail, the ambiguity is resolved.
|
💚 💙 💜 💛 ❤️ |
No description provided.