Soft-deprecate List.zip/1 in favor of Enum.zip/1 #13767
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
v0idpwn
reviewed
Aug 8, 2024
|
|
||
| """ | ||
| @spec zip([list]) :: [tuple] | ||
| @doc deprecated: "Use Enum.zip/1 instead" |
There was a problem hiding this comment.
Deprecated or not, I think it could be nice to delete the existing implementation and delegate to Enum.zip/1 :)
There was a problem hiding this comment.
Makes sense, I was hesitant since it will now support a list of enumerables and not just a list of lists... but that's not breaking, will go for it.
There was a problem hiding this comment.
That's a good point, maybe it wasn't a great idea. Let's see what people think
v0idpwn
approved these changes
Aug 8, 2024
whatyouhide
approved these changes
Aug 9, 2024
josevalim
approved these changes
Aug 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As discussed,
List.zip/1is actually less efficient than itsEnumcounterpart and doesn't make much sense API-wise.It seems it was just introduced a long time ago and was never removed after
Enum.zip/1got introduced.