WIP: Implement big year parsing #13720
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
josevalim
reviewed
Jul 13, 2024
| when calendar == Calendar.ISO do | ||
| "Date.new!(#{Integer.to_string(year)}, #{Integer.to_string(month)}, #{Integer.to_string(day)})" | ||
| when year in -9999..9999 do | ||
| "~D[" <> calendar.date_to_string(year, month, day) <> suffix(calendar) <> "]" | ||
| end | ||
|
|
||
| def inspect(%{calendar: calendar, year: year, month: month, day: day}, _) do |
There was a problem hiding this comment.
I think we should remove this clause and the guards. Just always invoke calendar.date_to_string. :)
There was a problem hiding this comment.
I was thinking that, but wanted to avoid a situation where a particular calendar implementation is inadvertently relying on year being in -9999..9999. I know there is a Jalaali calendar implementation I can test, not sure if there are others,
josevalim
reviewed
Jul 13, 2024
| @@ -216,6 +216,22 @@ defmodule Calendar.ISO do | |||
| ] | |||
| end | |||
|
|
|||
| [match_big_year, guard_big_year, match_big_year_rest, guard_big_year_rest, read_big_year_rest] = | |||
There was a problem hiding this comment.
What do you think about this: every time we see a + or - sign, we use Integer.parse to extract the year and then we parse the rest (month/day) using the patterns below? Would that simplify things a bit? But the general direction is good to me.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
WIP, but please critique. See #13712