-
Notifications
You must be signed in to change notification settings - Fork 3.4k
Add MissingDependenciesError exception #13689
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes from 1 commit
699b4ed
2c4008a
92e6635
e593af1
ad344ed
3ecae69
b95daaf
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -954,6 +954,18 @@ defmodule ExceptionTest do | |
test "ErlangError" do | ||
assert %ErlangError{original: :sample} |> message == "Erlang error: :sample" | ||
end | ||
|
||
test "MissingDependenciesError" do | ||
assert %MissingDependenciesError{ | ||
apps: [{:logger, "~> 1.18"}, {:ex_unit, Version.parse_requirement!(">= 0.0.0")}] | ||
} | ||
|> message == """ | ||
missing dependencies: | ||
|
||
* :logger (~> 1.18) | ||
* :ex_unit (>= 0.0.0) | ||
""" | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Here is my suggestion for the raising:
and it should raise:
I would keep them as tuples, because it is easier to copy and paste. There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more.
Good call. |
||
end | ||
end | ||
|
||
describe "error_info" do | ||
|
Uh oh!
There was an error while loading. Please reload this page.