Improvements to generated rel/bin/app.bat #13679
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Validate value of `!RELEASE_DISTRIBUTION!`
* Validate value of `!RELEASE_MODE!`
* Exit with `ERRORLEVEL` set to `1` on errors.
Previously we did not and so apps that use releases and rely on exit
codes to report errors were not doing so (e.g. Livebook).
* Rename rpc node name from `rem-(...)` to `rpc-(...)`
Also updates generated `rel/env.bat.exs`.
|
💚 💙 💜 💛 ❤️ |
josevalim
pushed a commit
that referenced
this pull request
Jul 2, 2024
* Validate value of `!RELEASE_MODE!`
* Exit with `ERRORLEVEL` set to `1` on errors.
Previously we did not and so apps that use releases and rely on exit
codes to report errors were not doing so (e.g. Livebook).
* Rename rpc node name from `rem-(...)` to `rpc-(...)`
* Update generated `rel/env.bat.exs`
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Validate value of
!RELEASE_DISTRIBUTION!Validate value of
!RELEASE_MODE!Exit with
ERRORLEVELset to1on errors.Previously we did not and so apps that use releases and rely on exit codes to report errors were not doing so (e.g. Livebook).
Rename rpc node name from
rem-(...)torpc-(...)Also updates generated
rel/env.bat.exs.