Skip to content

Correct example in the docs #13638

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jun 10, 2024
Merged

Conversation

vermaxik
Copy link
Contributor

@vermaxik vermaxik commented Jun 5, 2024

Small example typo in the Design-anti-patterns

{13, ""}
iex> AlternativeInteger.parse("13", discard_rest: false)
13
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we need to fix the code instead? We need to swap the if and else branches. WDYT?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yeah, thanks, you're right. fixed 🤗

@josevalim josevalim merged commit 9a06273 into elixir-lang:main Jun 10, 2024
@josevalim
Copy link
Member

💚 💙 💜 💛 ❤️

josevalim pushed a commit that referenced this pull request Jun 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants