Set-theoretic tuple types #13576
Closed
Set-theoretic tuple types #13576
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
josevalim
reviewed
May 20, 2024
| catch | ||
| :discard_negative -> tuple_empty?(tag, fields, negs) | ||
| end | ||
| end |
There was a problem hiding this comment.
Can we rewrite it to a non-raising versaion like the map one is currently implemented? :)
There was a problem hiding this comment.
Yes! I see this now thank you :)
josevalim
reviewed
May 20, 2024
| @@ -672,6 +686,19 @@ defmodule Module.Types.Descr do | |||
| end | |||
| end | |||
|
|
|||
| defp remove_optional(type) do | |||
There was a problem hiding this comment.
Let's use the existing pop_optional instead!
josevalim
reviewed
May 20, 2024
| defp tuple_union(left, right), do: map_union(left, right) | ||
|
|
||
| # Same as map_fetch, only the tuple descr field is accessed | ||
| def tuple_fetch(%{} = descr, key) do |
There was a problem hiding this comment.
Suggested change
| def tuple_fetch(%{} = descr, key) do | |
| def tuple_fetch(%{} = descr, key) when is_integer(key) do |
ericmj
reviewed
May 21, 2024
| for {neg_index, neg_type} <- neg_fields, not is_map_key(fields, neg_index) do | ||
| cond do | ||
| # This index is not in the closed positive tuple, so there is no value in common | ||
| # Tthere are no explicit optional types in tuples |
There was a problem hiding this comment.
Suggested change
| # Tthere are no explicit optional types in tuples | |
| # There are no explicit optional types in tuples |
|
Closing in favor of #13752. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds to the Descr tuple types
{:ok, binary(), integer()}and open tuple types{atom(), boolean(), ...}which represent every tuple of at least two elements that are an atom and a boolean.Tuples are encoded as map records, where the keys are the indices. E.g., type
{integer(), atom()}is encoded as type%{0 => integer(), 1 => atom()}and{atom(), boolean(), ...}is encoded as the open map%{..., 0 => atom(), 1 => boolean()}.Emptiness checking is slightly modified to account for the fact that tuple types do not admit explicit optional indices.