Add note about statically known maps keys and types tracking across function calls to the changelog #13562
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When reading the 1.17 changelog, in my opinion people less familiar with how typecheckers work can read too much into the promised improvements, and they might be disappointed afterwards when trying out the typechecker. For example, these two points especially:
mention maps in general, but if I understand correctly this will only work for maps in limited situations when the map type with its keys is statically known, e.g. when updating a map literal defined in the same function.
I think it's better not to over-promise, so I would propose adding some kind of caveat / info mention about the current general limitations of how the typechecker works. This wording and the caveat placement is probably not very good, but I wanted to open the PR to illustrate what I meant