Correct task remote vs. local documentation #13502
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The listed examples had the headings reversed. This is a documentation only change.
|
I think this was correct. You start the supervisor on the remote node. Then, you call |
|
Yes, the current comments are correct. If you feel they can be clarified in other ways, please let us know! |
|
Thanks for the review! I think what I misinterpreted was that this is a 2 step process and not an "either/or" . Perhaps if it said "First on the remote note ..." and then "Second on your local client" I would have seen this relationship clearly. Thoughts? Open to just closing this now! |
|
First and second sounds good! |
Avoid interpretation of this as 2 indidependent steps, but rather a two-step process setting up the remote clients readiness and then making the appropriate local calls to initiate the task.
|
I updated the text to my new interpretation. Please consider for re-review. Thanks! |
|
💚 💙 💜 💛 ❤️ |
gldubc
pushed a commit
to gldubc/elixir
that referenced
this pull request
Apr 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The listed examples had the headings reversed. This is a documentation only change.