Translate :undefined URI port to nil
#13464
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Resolves elixir-lang#13462 When a url string is schema less and the host is followed by a colon without setting the actual port, `:uri_string.parse/1` returns the port to be `:undefined`. As long as the url string is parseable, we should translate `:undefiend` to `nil`, in order to ensure we return a valid URI struct.
sabiwara
reviewed
Apr 1, 2024
lib/elixir/lib/uri.ex
Outdated
| @@ -666,6 +666,9 @@ defmodule URI do | |||
| end | |||
There was a problem hiding this comment.
I think the branch line 664 could also lead to an :undefined port?
There was a problem hiding this comment.
Absolutely right! I was able to reproduce using a scheme which has no port mapped through default_port/1 and added a test for it in ed85d09
|
💚 💙 💜 💛 ❤️ |
josevalim
pushed a commit
that referenced
this pull request
Apr 4, 2024
Resolves #13462 When a url string is schema less and the host is followed by a colon without setting the actual port, `:uri_string.parse/1` returns the port to be `:undefined`. As long as the url string is parseable, we should translate `:undefined` to `nil`, in order to ensure we return a valid URI struct.
josevalim
pushed a commit
that referenced
this pull request
May 6, 2024
Resolves #13462 When a url string is schema less and the host is followed by a colon without setting the actual port, `:uri_string.parse/1` returns the port to be `:undefined`. As long as the url string is parseable, we should translate `:undefined` to `nil`, in order to ensure we return a valid URI struct.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #13462
When a url string is schema less and the host is followed by a colon without setting the actual port,
:uri_string.parse/1returns the port to be:undefined. As long as the url string is parseable, we should translate:undefiendtonil, in order to ensure we return a valid URI struct.