Always use system certificates #13052
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The implementation of the function is small, so we can inline it: ssl_verify_host_options(WildcardHostName) ->
WildCard = case WildcardHostName of
true ->
Fun = public_key:pkix_verify_hostname_match_fun(https),
[{customize_hostname_check,[{match_fun, Fun}]}];
false ->
[]
end,
[{verify, verify_peer}, {cacerts, public_key:cacerts_get()} | WildCard].And then we leave a note to use |
Brilliant! Will do! |
sabiwara
force-pushed
the
always_check_cert
branch
2 times, most recently
from
c88c0f8 to
ed9fcd9
Compare
sabiwara
force-pushed
the
always_check_cert
branch
from
ed9fcd9 to
e6af52d
Compare
sabiwara
commented
Nov 1, 2023
Comment on lines
+662
to
+666
| ssl_options = [ | ||
| verify: :verify_peer, | ||
| cacerts: :public_key.cacerts_get(), | ||
| customize_hostname_check: [match_fun: :public_key.pkix_verify_hostname_match_fun(:https)] | ||
| ] |
There was a problem hiding this comment.
Original for comparison:
ssl_verify_host_options(WildcardHostName) ->
WildCard = case WildcardHostName of
true ->
Fun = public_key:pkix_verify_hostname_match_fun(https),
[{customize_hostname_check,[{match_fun, Fun}]}];
false ->
[]
end,
[{verify, verify_peer}, {cacerts, public_key:cacerts_get()} | WildCard].
josevalim
reviewed
Nov 1, 2023
josevalim
approved these changes
Nov 1, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Relates to #11220
Hope I didn't misunderstood "Use new system certificates" and the TODO, feel free to close if that's the case.
Note:
:httpc.ssl_verify_host_options/1is available from 25.1, which would imply 1.17 compatibility is from OTP 25.1, not 25 (is this a showstopper?).