Add support for automatic shutdown to Supervisor #12077
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bbhoss
force-pushed
the
supervisor-auto-shutdown
branch
from
796994b to
fcb6e45
Compare
|
Thank you. We also need to change both DynamicSupervisor and PartitionSupervisor to raise if |
|
Gotcha, I will try to submit those changes this week |
|
Updated. I didn't see any raising going on in the existing DynamicSupervisor code so I just matched the existing validation patterns. |
|
💚 💙 💜 💛 ❤️ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds support for Automatic Shutdown (EEP 56) to Supervisor. This functionality was added in Erlang R24 and leaks processes with older versions so should require 1.15. I believe it should have been listed in #10433 as well.
I tried to summarize the docs in a way that Elixir users wouldn't need to cross reference the OTP ones to use the feature, other than that it's mostly passing through options to
:supervisorand spec/doc updates.