Compiler hang on bamboo dependency

[lukaszsamson]

Elixir and Erlang/OTP versions

Erlang/OTP 26 [erts-14.2.5.4] [source] [64-bit] [smp:12:12] [ds:12:12:10] [async-threads:1] [jit]

Elixir 1.19.0-dev (a1c1888) (compiled with Erlang/OTP 26)

Operating system

macOS

Current behavior

Repro:

1. Create an empty mix project
2. Add {:bamboo, "~> 2.0"} & mix deps.get
3. Run mix compile

==> bamboo
Compiling 28 files (.ex)
Compiling lib/bamboo/adapters/mailgun_adapter.ex (it's taking more than 10s)
    warning: Plug.Cowboy.http/3 is undefined (module Plug.Cowboy is not available or is yet to be defined)
    │
 11 │     Plug.Cowboy.http(Bamboo.SentEmailViewerPlug, [], port: 4003)
    │                 ~
    │
    └─ lib/mix/start_sent_email_viewer_task.ex:11:17: Mix.Tasks.Bamboo.StartSentEmailViewer.run/1

No idea if it ever finishes. Ctrl+C killed after ~10 minutes on M2 mac

Expected behavior

Compilation in reasonable time

[sabiwara]

It seems to be Module.Types.infer stuck on Bamboo.MailgunAdapter.deliver/2.

It seems to be spending a lot on map_intersections:

iex(1)> :tprof.profile(Mix, :install, [[:bamboo]], %{type: :call_time, pattern: [{Module.Types.Descr,:_, :_}], timeout: 5000, report: {:total, {:measurement, :descending}}})
==> bamboo
Compiling 28 files (.ex)
FUNCTION                                                                         CALLS  TIME (us)  PER CALL  [    %]
'Elixir.Module.Types.Descr':'-map_intersection/2-fun-0-'/5                      327469    1991758      6.08  [41.37]
'Elixir.Module.Types.Descr':'non_empty_intersection!'/2                        4801319     579975      0.12  [12.05]
'Elixir.Module.Types.Descr':iterator_intersection/4                            4997862     432592      0.09  [ 8.98]
'Elixir.Module.Types.Descr':intersection/2                                     4803451     290828      0.06  [ 6.04]
'Elixir.Module.Types.Descr':'empty?'/1                                         5758318     281662      0.05  [ 5.85]
'Elixir.Module.Types.Descr':'zip_non_empty_intersection!'/3                    3439341     225738      0.07  [ 4.69]
'Elixir.Module.Types.Descr':'-tuple_intersection/2-fun-0-'/5                   1345971     145147      0.11  [ 3.01]
'Elixir.Module.Types.Descr':tuple_literal_intersection/4                       1345857     143906      0.11  [ 2.99]
'Elixir.Module.Types.Descr':'gradual?'/1                                       2608114     110737      0.04  [ 2.30]
'Elixir.Module.Types.Descr':'-map_literal_intersection/4-fun-1-'/3             2221486      99571      0.04  [ 2.07]
'Elixir.Module.Types.Descr':'-tuple_intersection/2-fun-1-'/3                    448832      77115      0.17  [ 1.60]
'Elixir.Module.Types.Descr':symmetrical_intersection/3                         1473783      76311      0.05  [ 1.58]
'Elixir.Module.Types.Descr':intersection/3                                     1004839      39958      0.04  [ 0.83]
'Elixir.Module.Types.Descr':'map_empty?'/3                                      261941      37788      0.14  [ 0.78]
'Elixir.Module.Types.Descr':iterator_merge/3                                    442789      34406      0.08  [ 0.71]
'Elixir.Module.Types.Descr':atom_intersection/2                                 433795      30172      0.07  [ 0.63]
'Elixir.Module.Types.Descr':tuple_intersection/2                                149752      27686      0.18  [ 0.58]
'Elixir.Module.Types.Descr':map_literal_intersection/4                          327321      26952      0.08  [ 0.56]
...

[sabiwara]

Thanks @lukaszsamson, I was waiting for a bench to try out my optimization idea 💜