Skip to content

chapter12_part3: /080_Structured_Search/10_compoundfilters.asciidoc #29

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

richardwei2008
Copy link

chapter12_part3: /080_Structured_Search/10_compoundfilters.asciidoc
第二部分:第12章,结构化搜索,组合过滤器

chapter12_part2: /080_Structured_Search/10_compoundfilters.asciidoc
第二部分:第12章,结构化搜索,组合过滤器
would you express this SQL in Elasticsearch?
前面的两个例子都是单个过滤器(filter)的使用方式。((("structured search", "combining filters")))((("filters", "combining"))) 在实际应用中,我们
很有可能会过滤多个值或字段。比方说,怎样
用 Elasticsearch 来表达下面的 SQL
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

“怎样”和“用”之间这个地方换行没有必要吧?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

是的,不应该手工换行的, medcl 也给我指正了

@richardwei2008 richardwei2008 changed the title chapter12_part2: /080_Structured_Search/10_compoundfilters.asciidoc chapter12_part3: /080_Structured_Search/10_compoundfilters.asciidoc Mar 12, 2016
fix:
1) 换行问题
2) 结合构成 -> 结合成 这样是否跟通顺?
3) Line 19: 此处应该用中文标点
4) Line 48: 括号里的非是否多余?
@medcl
Copy link
Member

medcl commented Mar 29, 2016

LGTM

1 similar comment
@xuej
Copy link

xuej commented Mar 31, 2016

LGTM

@medcl medcl merged commit cbba8f8 into elasticsearch-cn:cn Mar 31, 2016
@medcl medcl added done and removed to be merge labels May 31, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants