-
Notifications
You must be signed in to change notification settings - Fork 99
Java client issues batch 3 #2485
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
This reverts commit de46d9e.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Good improvements 🙂
model_id in ltr rescorer should not be optional Co-authored-by: Laurent Saint-Félix <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Following you can find the validation results for the APIs you have changed.
You can validate these APIs yourself by using the |
Fixes provided in this PR:
script
field. server code class, which extends this class, which has script.name
ormeta
fields.primaryTerm
in IndexResponse should be optional. no hard evidence from server, but running an indexing request with a noop pipeline (check the issue) effectively returns a response with noprimaryTerm
.escaped_tags
was missing from HtmlStripCharFilter. docs, server codeper_field_analyzer
in MoreLikeThisQuery should only be insidelike
and not a level above. server code where it's parsed at the same level as the other "like options".composite
as a RuntimeFieldType. docsmin
andmax
in ExtendedBounds should be optional. server code