Skip to content

Add force_synthethic_source parameter #2472

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 4, 2024
Merged

Conversation

pquentin
Copy link
Member

I noticed that force_synthetic_source was missing from this report:

"Request: missing json spec query parameter 'force_synthetic_source'"
. Do we typically add fields behind feature flags?

I checked the following things:

  • this parameter is not accepted as body parameter, either in get, mget or search
  • this parameter is not accepted in msearch at all

Copy link
Contributor

Following you can find the validation results for the APIs you have changed.

API Status Request Response
get 🔴 167/182 179/179
mget 🟢 52/52 51/51
search 🔴 1822/1925 1860/1907

You can validate these APIs yourself by using the make validate target.

@pquentin
Copy link
Member Author

It is an improvement! Here is the current state:

API Status Request Response
get 🔴 166/182 179/179
mget 🔴 50/52 51/51
search 🔴 1821/1925 1860/1907

Copy link
Contributor

@Anaethelion Anaethelion left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@pquentin pquentin merged commit bda8a6d into main Apr 4, 2024
@pquentin pquentin deleted the force-synthetic-source branch April 4, 2024 12:20
github-actions bot pushed a commit that referenced this pull request Apr 4, 2024
github-actions bot pushed a commit that referenced this pull request Apr 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants