Skip to content

Use consistent naming for API when used in a word #2465

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Mar 27, 2024
Merged

Conversation

swallez
Copy link
Member

@swallez swallez commented Mar 25, 2024

Renames APIKeyQueryContainer and APIKeyFiltersAggregation to use the same casing convention as the existing ApiKey, ApiKeyAuthorization, etc.

Copy link
Contributor

Following you can find the validation results for the APIs you have changed.

API Status Request Response
security.query_api_keys 🔴 14/14 1/14

You can validate these APIs yourself by using the make validate target.

@l-trotta l-trotta merged commit 071b2f7 into main Mar 27, 2024
@l-trotta l-trotta deleted the consistent-api-casing branch March 27, 2024 10:42
github-actions bot pushed a commit that referenced this pull request Mar 27, 2024
* Use consistent naming for API when used in a word

* More renaming

(cherry picked from commit 071b2f7)
l-trotta pushed a commit that referenced this pull request Mar 27, 2024
* Use consistent naming for API when used in a word

* More renaming

(cherry picked from commit 071b2f7)

Co-authored-by: Sylvain Wallez <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants