Skip to content

Make index settings blocks stringified #2111

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
May 12, 2023
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/workflows/validate-pr.yml
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,7 @@ jobs:
if: github.repository_owner == 'elastic' # this action will fail if executed from a fork
runs-on: ubuntu-latest
env:
STACK_VERSION: 8.6-SNAPSHOT
STACK_VERSION: 8.9-SNAPSHOT

steps:
- uses: actions/checkout@v2
Expand Down
54 changes: 39 additions & 15 deletions output/schema/schema.json

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

8 changes: 4 additions & 4 deletions output/typescript/types.ts

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

8 changes: 4 additions & 4 deletions specification/indices/_types/IndexSettings.ts
Original file line number Diff line number Diff line change
Expand Up @@ -243,10 +243,10 @@ export class SettingsQueryString {
}

export class IndexSettingBlocks {
read_only?: boolean
read_only_allow_delete?: boolean
read?: boolean
write?: boolean | string // TODO: should be bool only
read_only?: Stringified<boolean>
read_only_allow_delete?: Stringified<boolean>
read?: Stringified<boolean>
write?: Stringified<boolean>
metadata?: Stringified<boolean>
}

Expand Down