Skip to content

Add missing property for MultiTerms aggregation #2000

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Dec 21, 2022

Conversation

stevejgordon
Copy link
Contributor

Adds a missing property for MultiTermLookup to support providing a missing value per the documentation.

Raised in elastic/elasticsearch-net#7119

@stevejgordon stevejgordon force-pushed the add-missing-to-multiterms-aggregation branch from 685a81e to adfdba7 Compare December 21, 2022 09:30
@ezimuel ezimuel assigned ezimuel and unassigned ezimuel Dec 21, 2022
@ezimuel ezimuel self-requested a review December 21, 2022 09:45
Copy link
Contributor

@ezimuel ezimuel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@stevejgordon stevejgordon merged commit 9cc32ae into main Dec 21, 2022
@stevejgordon stevejgordon deleted the add-missing-to-multiterms-aggregation branch December 21, 2022 09:46
@github-actions
Copy link
Contributor

The backport to 7.17 failed:

The process '/usr/bin/git' failed with exit code 1

To backport manually, run these commands in your terminal:

# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add .worktrees/backport-7.17 7.17
# Navigate to the new working tree
cd .worktrees/backport-7.17
# Create a new branch
git switch --create backport-2000-to-7.17
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick --mainline 1 9cc32aeefffbcf62c5d7b1e94110c759caac5bb8
# Push it to GitHub
git push --set-upstream origin backport-2000-to-7.17
# Go back to the original working tree
cd ../..
# Delete the working tree
git worktree remove .worktrees/backport-7.17

Then, create a pull request where the base branch is 7.17 and the compare/head branch is backport-2000-to-7.17.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants