Skip to content

Add default value for internal tags #1589

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 29, 2022
Merged

Add default value for internal tags #1589

merged 1 commit into from
Mar 29, 2022

Conversation

swallez
Copy link
Member

@swallez swallez commented Mar 29, 2022

Adds an optional default configuration to internally tagged union definitions, e.g. @variants internal tag='type' default='object'

This is needed for:

Copy link
Member

@delvedor delvedor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@swallez swallez merged commit c61a7c7 into main Mar 29, 2022
@swallez swallez deleted the default-internal-tag branch March 29, 2022 17:04
@github-actions
Copy link
Contributor

The backport to 8.0 failed:

The process '/usr/bin/git' failed with exit code 1

To backport manually, run these commands in your terminal:

# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add .worktrees/backport-8.0 8.0
# Navigate to the new working tree
cd .worktrees/backport-8.0
# Create a new branch
git switch --create backport-1589-to-8.0
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick --mainline 1 c61a7c773da33e1d9ff36a5d4a221dae21f43c30
# Push it to GitHub
git push --set-upstream origin backport-1589-to-8.0
# Go back to the original working tree
cd ../..
# Delete the working tree
git worktree remove .worktrees/backport-8.0

Then, create a pull request where the base branch is 8.0 and the compare/head branch is backport-1589-to-8.0.

github-actions bot pushed a commit that referenced this pull request Mar 29, 2022
github-actions bot pushed a commit that referenced this pull request Mar 29, 2022
swallez added a commit that referenced this pull request Mar 29, 2022
swallez added a commit that referenced this pull request Mar 29, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants