Skip to content

Add missing match_only_text field mapping #1549

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Mar 21, 2022
Merged

Add missing match_only_text field mapping #1549

merged 6 commits into from
Mar 21, 2022

Conversation

philkra
Copy link
Contributor

@philkra philkra commented Mar 18, 2022

closes #1548

@philkra philkra requested a review from swallez March 18, 2022 18:17
Copy link
Member

@swallez swallez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks!

@philkra philkra merged commit c62bd4c into main Mar 21, 2022
@philkra philkra deleted the issue-1548 branch March 21, 2022 14:13
@github-actions
Copy link
Contributor

The backport to 8.0 failed:

The process '/usr/bin/git' failed with exit code 1

To backport manually, run these commands in your terminal:

# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add .worktrees/backport-8.0 8.0
# Navigate to the new working tree
cd .worktrees/backport-8.0
# Create a new branch
git switch --create backport-1549-to-8.0
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick --mainline 1 c62bd4c26cf651162c388c44cd0139792ef4867e
# Push it to GitHub
git push --set-upstream origin backport-1549-to-8.0
# Go back to the original working tree
cd ../..
# Delete the working tree
git worktree remove .worktrees/backport-8.0

Then, create a pull request where the base branch is 8.0 and the compare/head branch is backport-1549-to-8.0.

@github-actions
Copy link
Contributor

The backport to 7.17 failed:

The process '/usr/bin/git' failed with exit code 1

To backport manually, run these commands in your terminal:

# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add .worktrees/backport-7.17 7.17
# Navigate to the new working tree
cd .worktrees/backport-7.17
# Create a new branch
git switch --create backport-1549-to-7.17
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick --mainline 1 c62bd4c26cf651162c388c44cd0139792ef4867e
# Push it to GitHub
git push --set-upstream origin backport-1549-to-7.17
# Go back to the original working tree
cd ../..
# Delete the working tree
git worktree remove .worktrees/backport-7.17

Then, create a pull request where the base branch is 7.17 and the compare/head branch is backport-1549-to-7.17.

@github-actions
Copy link
Contributor

The backport to 8.1 failed:

The process '/usr/bin/git' failed with exit code 1

To backport manually, run these commands in your terminal:

# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add .worktrees/backport-8.1 8.1
# Navigate to the new working tree
cd .worktrees/backport-8.1
# Create a new branch
git switch --create backport-1549-to-8.1
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick --mainline 1 c62bd4c26cf651162c388c44cd0139792ef4867e
# Push it to GitHub
git push --set-upstream origin backport-1549-to-8.1
# Go back to the original working tree
cd ../..
# Delete the working tree
git worktree remove .worktrees/backport-8.1

Then, create a pull request where the base branch is 8.1 and the compare/head branch is backport-1549-to-8.1.

swallez added a commit that referenced this pull request Mar 21, 2022
* boy scouting

* boy scouting #2

* Add type match_only_text

* Update specification/_types/mapping/core.ts

Co-authored-by: Sylvain Wallez <[email protected]>

* Update specification/_types/mapping/core.ts

Co-authored-by: Sylvain Wallez <[email protected]>

* add match_text_only to known types

Co-authored-by: Sylvain Wallez <[email protected]>
swallez added a commit that referenced this pull request Mar 21, 2022
* boy scouting

* boy scouting #2

* Add type match_only_text

* Update specification/_types/mapping/core.ts

Co-authored-by: Sylvain Wallez <[email protected]>

* Update specification/_types/mapping/core.ts

Co-authored-by: Sylvain Wallez <[email protected]>

* add match_text_only to known types

Co-authored-by: Sylvain Wallez <[email protected]>
swallez added a commit that referenced this pull request Mar 21, 2022
* boy scouting

* boy scouting #2

* Add type match_only_text

* Update specification/_types/mapping/core.ts

Co-authored-by: Sylvain Wallez <[email protected]>

* Update specification/_types/mapping/core.ts

Co-authored-by: Sylvain Wallez <[email protected]>

* add match_text_only to known types

Co-authored-by: Sylvain Wallez <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Missing match_only_text field mapping.
2 participants