Skip to content

Support Python 3.13 #88

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Nov 7, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions .buildkite/generatesteps.py
Original file line number Diff line number Diff line change
Expand Up @@ -54,9 +54,9 @@ def benchmark_to_steps(python, connection_class, nox_session):

if __name__ == "__main__":
steps = []
for python in ["3.9", "3.10", "3.11", "3.12"]:
for python in ["3.9", "3.10", "3.11", "3.12", "3.13"]:
for connection_class in ["urllib3", "requests"]:
steps.extend(benchmark_to_steps(python, connection_class, "test"))
steps.extend(benchmark_to_steps("3.9", "urllib3", "test_otel"))
steps.extend(benchmark_to_steps("3.12", "urllib3", "test_otel"))
steps.extend(benchmark_to_steps("3.13", "urllib3", "test_otel"))
print(yaml.dump({"steps": steps}, Dumper=yaml.Dumper, sort_keys=False))
4 changes: 2 additions & 2 deletions .buildkite/teardown-tests
Original file line number Diff line number Diff line change
Expand Up @@ -2,13 +2,13 @@
set -euo pipefail

# Default environment variables
export PYTHON_VERSION="${PYTHON_VERSION:=3.12}"
export PYTHON_VERSION="${PYTHON_VERSION:=3.13}"
export PYTHON_CONNECTION_CLASS="${PYTHON_CONNECTION_CLASS:=urllib3}"
export EC_PROJECT_NAME=$(buildkite-agent meta-data get $EC_PROJECT_PREFIX)

# fetch cloud creds used by qaf
CLOUD_ACCESS_KEY=$(vault read -field="$EC_ENV" secret/ci/elastic-elasticsearch-serverless-python/cloud-access)
echo "{\"api_key\":{\"$EC_ENV\":\"$CLOUD_ACCESS_KEY\"}}" > "$(pwd)/cloud.json"
echo "{\"api_key\":{\"$EC_ENV\":\"$CLOUD_ACCESS_KEY\"}}" >"$(pwd)/cloud.json"

run_qaf() {
cmd=$1
Expand Down
2 changes: 1 addition & 1 deletion .github/Dockerfile
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
ARG PYTHON_VERSION=3.12
ARG PYTHON_VERSION=3.13
FROM python:${PYTHON_VERSION}

WORKDIR /code/elasticsearch-serverless-python
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/tests.yml
Original file line number Diff line number Diff line change
Expand Up @@ -59,7 +59,7 @@ jobs:
strategy:
fail-fast: false
matrix:
python-version: ["3.9", "3.10", "3.11", "3.12"]
python-version: ["3.9", "3.10", "3.11", "3.12", "3.13"]
experimental: [false]
nox-session: [""]
runs-on: ["ubuntu-latest"]
Expand Down
4 changes: 2 additions & 2 deletions noxfile.py
Original file line number Diff line number Diff line change
Expand Up @@ -47,14 +47,14 @@ def pytest_argv():
]


@nox.session(python=["3.9", "3.10", "3.11", "3.12"])
@nox.session(python=["3.9", "3.10", "3.11", "3.12", "3.13"])
def test(session):
session.install(".[dev]", env=INSTALL_ENV)

session.run(*pytest_argv(), *(session.posargs))


@nox.session(python=["3.9", "3.12"])
@nox.session(python=["3.9", "3.13"])
def test_otel(session):
session.install(".[dev]", env=INSTALL_ENV)
session.install("opentelemetry-api", "opentelemetry-sdk")
Expand Down
1 change: 1 addition & 0 deletions pyproject.toml
Original file line number Diff line number Diff line change
Expand Up @@ -26,6 +26,7 @@ classifiers = [
"Programming Language :: Python :: 3.10",
"Programming Language :: Python :: 3.11",
"Programming Language :: Python :: 3.12",
"Programming Language :: Python :: 3.13",
"Programming Language :: Python :: Implementation :: CPython",
"Programming Language :: Python :: Implementation :: PyPy",
]
Expand Down
Loading